Don't use embed video on community page #5159
Open
+47
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChunkyProgrammer
requested review from
unixfox
and removed request for
a team
ChunkyProgrammer
force-pushed
the
dont-use-embed-video-on-com-page
branch
from
550dd39 to
9b6c28f
Compare
ChunkyProgrammer
force-pushed
the
dont-use-embed-video-on-com-page
branch
from
9b6c28f to
97a7e19
Compare
SamantazFox
approved these changes
Sep 13, 2025
Member
SamantazFox
left a comment
SamantazFox
left a comment
There was a problem hiding this comment.
Looks good to me! I've made two small suggestions to reduce duplicated code.
Co-authored-by: Samantaz Fox <[email protected]>
ChunkyProgrammer
force-pushed
the
dont-use-embed-video-on-com-page
branch
from
45f532c to
d5dfceb
Compare
SamantazFox
approved these changes
Sep 14, 2025
SamantazFox
added
the
need-testing
SamantazFox
added
ready
and removed
need-testing
Fijxu
requested changes
Dec 14, 2025
Comment on lines
+109
to
+115
| if thin_mode | ||
| html << %(<img loading="lazy" class="thumbnail" src="/vi/) | ||
| html << attachment["videoId"] | ||
| html << %(/mqdefault.jpg" alt="" />) | ||
| else | ||
| html << %(<div class="bottom-right-overlay">) | ||
| end |
Member
There was a problem hiding this comment.
Suggested change
| if thin_mode | |
| html << %(<img loading="lazy" class="thumbnail" src="/vi/) | |
| html << attachment["videoId"] | |
| html << %(/mqdefault.jpg" alt="" />) | |
| else | |
| html << %(<div class="bottom-right-overlay">) | |
| end | |
| if thin_mode | |
| html << %(<div class="bottom-right-overlay">) | |
| else | |
| html << %(<img loading="lazy" class="thumbnail" src="/vi/) | |
| html << attachment["videoId"] | |
| html << %(/mqdefault.jpg" alt="" />) | |
| end |
Logic issue, when thin_mode is true IT SHOULDN'T show a thumbnail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR:
video attachments for community posts would load an embedded video page (fetching video data, streaming links, etc.) and allowed playing the video within the community page. I imagine this could cause some rate limit issues + some unnecessary strain on some invidious instances (especially if there's multiple videos on the community page being loaded)
After this PR:
Thumbnail and some video data is shown as a link to the video page. Channel is also shown since I believe it's possible for channels to attach a video from channels that aren't there own.